Skip to content

Add runtime operations in WFE#59966

Merged
salmart-dev merged 1 commit into
masterfrom
feature/workflow-app-rules
May 18, 2026
Merged

Add runtime operations in WFE#59966
salmart-dev merged 1 commit into
masterfrom
feature/workflow-app-rules

Conversation

@salmart-dev
Copy link
Copy Markdown
Contributor

@salmart-dev salmart-dev commented Apr 28, 2026

Summary

Introduces runtime operations to the Workflow Engine

Sometimes apps may want to hook into the WFE event/check pipeline without surfacing those flows to administrators or users. Classic WFE operations are stored in the DB and fully visible and editable via the UI. Runtime operations fill the gap for programmatically defined, app-internal flows.

Registration flow

At boot, the WFE application dispatches RegisterRuntimeOperationsEvent (note it's internal) before registerRuleListeners runs. Internal apps can listen to this event and call Manager::addRuntimeOperation() as needed.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@salmart-dev salmart-dev self-assigned this Apr 28, 2026
@salmart-dev salmart-dev added the 3. to review Waiting for reviews label Apr 28, 2026
@salmart-dev salmart-dev force-pushed the feature/workflow-app-rules branch 3 times, most recently from 7eff7fc to d19fe62 Compare April 28, 2026 16:06
@salmart-dev salmart-dev changed the title Merge pull request #59942 from nextcloud/fix/view-destructure Add runtime operations in WFE Apr 29, 2026
@salmart-dev salmart-dev force-pushed the feature/workflow-app-rules branch 3 times, most recently from 07960ec to 5741066 Compare April 29, 2026 13:03
@salmart-dev salmart-dev marked this pull request as ready for review May 5, 2026 11:09
@salmart-dev salmart-dev requested review from ArtificialOwl, nfebe, provokateurin and sorbaugh and removed request for a team May 5, 2026 11:09
Comment thread apps/workflowengine/lib/Manager.php
Copy link
Copy Markdown
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test, overall it looks good, two non-blocking suggestions.

Comment thread apps/workflowengine/lib/AppInfo/Application.php Outdated
Comment thread apps/workflowengine/lib/Manager.php Outdated
Comment thread lib/private/WorkflowEngine/Events/RegisterRuntimeOperationsEvent.php Outdated
Comment thread apps/workflowengine/lib/AppInfo/Application.php Outdated
@salmart-dev salmart-dev force-pushed the feature/workflow-app-rules branch from 4ab7e88 to 9a5b09f Compare May 13, 2026 07:23
Copy link
Copy Markdown
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>

# Conflicts:
#	apps/workflowengine/lib/Manager.php
@salmart-dev salmart-dev force-pushed the feature/workflow-app-rules branch from 561d3bd to 2a9036a Compare May 18, 2026 10:24
@salmart-dev
Copy link
Copy Markdown
Contributor Author

/backport to stable34 please

@salmart-dev salmart-dev added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 18, 2026
@salmart-dev salmart-dev added this to the Nextcloud 34 milestone May 18, 2026
@salmart-dev salmart-dev merged commit f55b3fb into master May 18, 2026
215 of 230 checks passed
@salmart-dev salmart-dev deleted the feature/workflow-app-rules branch May 18, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants